Change in coreboot[master]: util/ifdtool: Add Jasperlake platform support under IFDv2 - coreboot-gerrit

27 Nov 2019


      Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37111 )
Change subject: util/ifdtool: Add Jasperlake platform support under IFDv2
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37111/5/util/ifdtool/ifdtool.c 
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/37111/5/util/ifdtool/ifdtool.c@1641 
PS5, Line 1641: } else if (!strcmp(optarg, "jsl")) {
              :                                 platform = PLATFORM_JSL;
What's the point in all these compatible IFD arguments? If no distinction is made just document which ones are compatible?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/37111
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4963ab249a8e0b31c014e92edf1e0a4a4f638084
Gerrit-Change-Number: 37111
Gerrit-PatchSet: 5
Gerrit-Owner: Ronak Kanabar ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath meera.ravindranath@intel.com
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar ronak.kanabar@intel.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 27 Nov 2019 13:10:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment