Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34475 )
Change subject: Add Razer Blade Stealth (2016) H2U ......................................................................
Patch Set 26:
(7 comments)
https://review.coreboot.org/c/coreboot/+/34475/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34475/6//COMMIT_MSG@10 PS6, Line 10: - A way to determin equipped ram (help appreciated)
Only have this one board and don't have the schematics
Done
https://review.coreboot.org/c/coreboot/+/34475/6//COMMIT_MSG@13 PS6, Line 13: - HDA double-checking (just copied from kblrvp)
Not sure, but is it possible to read this out of the registers with oem firmware?
Done
https://review.coreboot.org/c/coreboot/+/34475/6//COMMIT_MSG@41 PS6, Line 41: - Headphones
most likely because of incorrect HDA configuration
Done
https://review.coreboot.org/c/coreboot/+/34475/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34475/7//COMMIT_MSG@10 PS7, Line 10: - A way to determin equipped ram (help appreciated)
Usually some platform ID GPIOs are used. […]
Done
https://review.coreboot.org/c/coreboot/+/34475/7//COMMIT_MSG@42 PS7, Line 42: - Onboard Keyboard in SeaBIOS
I used the vendor ACPI table and the expected results to RE some RAM values. […]
Done
https://review.coreboot.org/c/coreboot/+/34475/7/src/mainboard/razer/blade_s... File src/mainboard/razer/blade_stealth_kbl/Kconfig:
https://review.coreboot.org/c/coreboot/+/34475/7/src/mainboard/razer/blade_s... PS7, Line 24: INTEL_GMA_ADD_VBT
It does not seem to get added. […]
Done
https://review.coreboot.org/c/coreboot/+/34475/9/src/mainboard/razer/blade_s... File src/mainboard/razer/blade_stealth_kbl/spd/spd_util.c:
https://review.coreboot.org/c/coreboot/+/34475/9/src/mainboard/razer/blade_s... PS9, Line 53: : : : : : :
Do these need to be specified? weird...
Done