Attention is currently required from: Joel Linn, Matt DeVillier, Nicholas Chin.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81368?usp=email )
Change subject: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge) ......................................................................
Patch Set 3:
(9 comments)
File src/mainboard/hp/pro_3500_series/Kconfig:
https://review.coreboot.org/c/coreboot/+/81368/comment/644bd349_6e58ea21 : PS3, Line 11: select INTEL_INT15 See my comment for mainboard.c
File src/mainboard/hp/pro_3500_series/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/81368/comment/9fe092eb_8db92587 : PS3, Line 11: bootblock-y += led.c Move to the other bootblock lines
File src/mainboard/hp/pro_3500_series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/81368/comment/7472b1dd_34c3d236 : PS3, Line 4: register "gpu_dp_b_hotplug" = "0" : register "gpu_dp_c_hotplug" = "0" : register "gpu_dp_d_hotplug" = "0" Set to 0 by default, remove
https://review.coreboot.org/c/coreboot/+/81368/comment/7370fe96_1f6a6e86 : PS3, Line 15: # Host bridge Host bridge Remove superfluous comment
https://review.coreboot.org/c/coreboot/+/81368/comment/16d40c26_c1d3746e : PS3, Line 19: chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH Remove devices which are set to off, as their config is equal to chipset devicetree.
https://review.coreboot.org/c/coreboot/+/81368/comment/807b3595_7f769b65 : PS3, Line 22: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" All set to 0, remove
File src/mainboard/hp/pro_3500_series/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/81368/comment/83f1aca3_0aa49c5a : PS3, Line 14: /* OEM revision */ Remove comment
File src/mainboard/hp/pro_3500_series/mainboard.c:
PS3: The INT15 handler is only needed when the proprietary VGA bios is used. It's useless with libgfxinit. I would just drop it.
File src/mainboard/hp/pro_3500_series/smihandler.c:
https://review.coreboot.org/c/coreboot/+/81368/comment/e923131c_c9fa5aad : PS3, Line 12: */ No need for multiline comment, just use single line format