Attention is currently required from: Yidi Lin.
Hello Yidi Lin,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/85948?usp=email
to review the following change.
Change subject: soc/mediatek: Change parameter type to u8 in dptx_hal_set_txlane api ......................................................................
soc/mediatek: Change parameter type to u8 in dptx_hal_set_txlane api
TEST=build pass BUG=b:343351631
Change-Id: I60bbb2c37811655692a5a8cd9f942fed4ead8abb Signed-off-by: Bincai Liu bincai.liu@mediatek.corp-partner.google.com Signed-off-by: Yidi Lin yidilin@chromium.org --- M src/soc/mediatek/common/dp/dptx_hal.c M src/soc/mediatek/common/dp/include/soc/dptx_hal_common.h 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/85948/1
diff --git a/src/soc/mediatek/common/dp/dptx_hal.c b/src/soc/mediatek/common/dp/dptx_hal.c index 28a1480..fde8e84 100644 --- a/src/soc/mediatek/common/dp/dptx_hal.c +++ b/src/soc/mediatek/common/dp/dptx_hal.c @@ -220,7 +220,7 @@ mtk_dp_write_byte(mtk_dp, 0x1038, BIT(0), BIT(0)); }
-void dptx_hal_set_txlane(struct mtk_dp *mtk_dp, int value) +void dptx_hal_set_txlane(struct mtk_dp *mtk_dp, u8 value) { if (value == 0) mtk_dp_write_byte(mtk_dp, REG_35F0_DP_TRANS_P0, diff --git a/src/soc/mediatek/common/dp/include/soc/dptx_hal_common.h b/src/soc/mediatek/common/dp/include/soc/dptx_hal_common.h index 7f0e30f..7cab11c 100644 --- a/src/soc/mediatek/common/dp/include/soc/dptx_hal_common.h +++ b/src/soc/mediatek/common/dp/include/soc/dptx_hal_common.h @@ -81,7 +81,7 @@ void dptx_hal_phy_setting(struct mtk_dp *mtk_dp); void dptx_hal_aux_setting(struct mtk_dp *mtk_dp); void dptx_hal_digital_setting(struct mtk_dp *mtk_dp); -void dptx_hal_set_txlane(struct mtk_dp *mtk_dp, int value); +void dptx_hal_set_txlane(struct mtk_dp *mtk_dp, u8 value); void dptx_hal_phy_setidlepattern(struct mtk_dp *mtk_dp, bool enable); void dptx_hal_phyd_reset(struct mtk_dp *mtk_dp); void dptx_hal_set_txtrainingpattern(struct mtk_dp *mtk_dp, int value);