Change in coreboot[master]: soc/intel/common/block/cse: Make cse_request_global_reset() static

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45342 )

Change subject: soc/intel/common/block/cse: Make cse_request_global_reset() static
......................................................................

soc/intel/common/block/cse: Make cse_request_global_reset() static

Common reset.c code block will make use of cse_send_global_reset() function
directly from common code block hence don't need to make redundant
function for sending same CSE global reset command, hence making
cse_request_global_reset() function static.

Signed-off-by: Subrata Banik 
Change-Id: Iae6ad47f0a24da05976ead700d7330bf8f7395d0
---
M src/soc/intel/common/block/cse/cse.c
M src/soc/intel/common/block/include/intelblocks/cse.h
2 files changed, 1 insertion(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/45342/1

diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c
index 90afdcf..e564cf7 100644
--- a/src/soc/intel/common/block/cse/cse.c
+++ b/src/soc/intel/common/block/cse/cse.c
@@ -618,7 +618,7 @@
 /*
  * Sends GLOBAL_RESET_REQ cmd to CSE.The reset type can be GLOBAL_RESET/CSE_RESET_ONLY.
  */
-int cse_request_global_reset(enum rst_req_type rst_type)
+static int cse_request_global_reset(enum rst_req_type rst_type)
 {
    int status;
    struct mkhi_hdr reply;
diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h
index 9804b0d..e4ba836 100644
--- a/src/soc/intel/common/block/include/intelblocks/cse.h
+++ b/src/soc/intel/common/block/include/intelblocks/cse.h
@@ -122,12 +122,6 @@

/*
  * Sends GLOBAL_RESET_REQ cmd to CSE.
- * The reset type can be one of the above defined reset type.
- * Returns 0 on failure and 1 on success.
- */
-int cse_request_global_reset(enum rst_req_type rst_type);
-/*
- * Sends GLOBAL_RESET_REQ cmd to CSE.
  * 1. Check if CSE is enable from devicetree.cb
  * 2. Ensure CSE in Normal Mode prior sending global reset command
  * 3. If not in normal mode then send error status

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45342 )

Change subject: soc/intel/common/block/cse: Make cse_request_global_reset() static
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45342/1/src/soc/intel/common/block/... 
File src/soc/intel/common/block/include/intelblocks/cse.h:

https://review.coreboot.org/c/coreboot/+/45342/1/src/soc/intel/common/block/... 
PS1, Line 120: CSE_RESET_ONLY
Then, how would one send this reset type to CSE?

[Subrata Banik (Code Review)]

Subrata Banik has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45342 )

Change subject: soc/intel/common/block/cse: Make cse_request_global_reset() static
......................................................................

Abandoned