Attention is currently required from: Ruihai Zhou.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75488?usp=email )
Change subject: soc/mediatek/common: Add support for power supply TPS65132S
......................................................................
Patch Set 5:
(2 comments)
File src/soc/mediatek/common/tps65132s.c:
https://review.coreboot.org/c/coreboot/+/75488/comment/99a5db69_b8362c1c :
PS5, Line 35: mdelay(10);
Where do these delays come from?
https://review.coreboot.org/c/coreboot/+/75488/comment/63da1d64_5c0ba5de :
PS5, Line 62: mdelay(50);
For such long delays, a comment mentioning section in the datasheet would be nice.
[1]: https://www.ti.com/lit/ds/symlink/tps65132.pdf?ts=1685628433524&ref_url=...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75488?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad2c9bdea5824455efcef18b44876111061cfa1a
Gerrit-Change-Number: 75488
Gerrit-PatchSet: 5
Gerrit-Owner: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Thu, 01 Jun 2023 14:10:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment