HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45066 )
Change subject: mb/*/Kconfig: Add missing 'int' for UART_FOR_CONSOLE ......................................................................
mb/*/Kconfig: Add missing 'int' for UART_FOR_CONSOLE
Change-Id: I7b49753c0eb0330990e41716d5c73913e4683487 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/hatch/Kconfig M src/mainboard/intel/apollolake_rvp/Kconfig M src/mainboard/intel/leafhill/Kconfig M src/mainboard/intel/minnow3/Kconfig M src/mainboard/siemens/mc_apl1/Kconfig M src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig 6 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/45066/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index ee9210d..95ea7f8 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -90,6 +90,7 @@ default 0x1
config UART_FOR_CONSOLE + int default 0
if BOARD_GOOGLE_BASEBOARD_HATCH diff --git a/src/mainboard/intel/apollolake_rvp/Kconfig b/src/mainboard/intel/apollolake_rvp/Kconfig index dfd86eb..7d56566 100644 --- a/src/mainboard/intel/apollolake_rvp/Kconfig +++ b/src/mainboard/intel/apollolake_rvp/Kconfig @@ -16,5 +16,6 @@ default "Apollolake RVP"
config UART_FOR_CONSOLE + int default 2 endif diff --git a/src/mainboard/intel/leafhill/Kconfig b/src/mainboard/intel/leafhill/Kconfig index 652a659..d13b493 100644 --- a/src/mainboard/intel/leafhill/Kconfig +++ b/src/mainboard/intel/leafhill/Kconfig @@ -20,6 +20,7 @@ default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/leafhill.$(CONFIG_COREBOOT_ROMSIZE_KB).fmd"
config UART_FOR_CONSOLE + int default 2
config NEED_IFWI diff --git a/src/mainboard/intel/minnow3/Kconfig b/src/mainboard/intel/minnow3/Kconfig index 0c86df6..9c1491b 100644 --- a/src/mainboard/intel/minnow3/Kconfig +++ b/src/mainboard/intel/minnow3/Kconfig @@ -20,6 +20,7 @@ default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/minnow3.fmd"
config UART_FOR_CONSOLE + int default 2
config NEED_IFWI diff --git a/src/mainboard/siemens/mc_apl1/Kconfig b/src/mainboard/siemens/mc_apl1/Kconfig index 0fe4a25..031394e 100644 --- a/src/mainboard/siemens/mc_apl1/Kconfig +++ b/src/mainboard/siemens/mc_apl1/Kconfig @@ -38,6 +38,7 @@ default "MC APL6" if BOARD_SIEMENS_MC_APL6
config UART_FOR_CONSOLE + int default 2
config MAX_CPUS diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig index 50a390b..a7eb8eb 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig @@ -12,6 +12,7 @@ select TPM_MEASURED_BOOT
config UART_FOR_CONSOLE + int default 1
config CBFS_SIZE
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45066 )
Change subject: mb/*/Kconfig: Add missing 'int' for UART_FOR_CONSOLE ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45066 )
Change subject: mb/*/Kconfig: Add missing 'int' for UART_FOR_CONSOLE ......................................................................
Patch Set 1: Code-Review-1
AFAICS, the type is omitted on purpose. To make it clear that these just specify the default and the actual option is declared somewhere else.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45066 )
Change subject: mb/*/Kconfig: Add missing 'int' for UART_FOR_CONSOLE ......................................................................
Patch Set 1:
Patch Set 1: Code-Review-1
AFAICS, the type is omitted on purpose. To make it clear that these just specify the default and the actual option is declared somewhere else.
Thank you. it means that in some cases , as in here: src/mainboard/facebook/monolith/Kconfig the "int" type is redundant, isn't it?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45066 )
Change subject: mb/*/Kconfig: Add missing 'int' for UART_FOR_CONSOLE ......................................................................
Patch Set 1:
AFAICS, the type is omitted on purpose. To make it clear that these just specify the default and the actual option is declared somewhere else.
Thank you. it means that in some cases , as in here: src/mainboard/facebook/monolith/Kconfig the "int" type is redundant, isn't it?
Technically, it's redundant, yes. We don't have a written rule about it though, AFAIK. See comment on CB:45121.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45066 )
Change subject: mb/*/Kconfig: Add missing 'int' for UART_FOR_CONSOLE ......................................................................
Patch Set 1: Code-Review-1
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45066 )
Change subject: mb/*/Kconfig: Add missing 'int' for UART_FOR_CONSOLE ......................................................................
Patch Set 1:
Kconfig will not complaint if you enter for exmple "10" as a value for an hex. It will be used as "0x10". So, my 1rst idea here is to eliminate any confusion and remember taht here it is an "int" expected.
after some thought, wondering if it is a good idea to remove redundant types in CB:45121
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45066 )
Change subject: mb/*/Kconfig: Add missing 'int' for UART_FOR_CONSOLE ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)
-
Werner Zeh (Code Review)