Change in coreboot[master]: lib/fls: Add fls support - coreboot-gerrit

1 Dec 2021


      Attention is currently required from: Hung-Te Lin, Shelley Chen, Paul Menzel, Julius Werner, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59738 )
Change subject: lib/fls: Add fls support
......................................................................
Patch Set 2:
(2 comments)
File src/commonlib/bsd/include/commonlib/bsd/helpers.h:
https://review.coreboot.org/c/coreboot/+/59738/comment/8b6c1564_0b14776e 
PS1, Line 132: @x: the word to search
...
@param x    Input number.
Ack
https://review.coreboot.org/c/coreboot/+/59738/comment/424ec634_9c6195ff 
PS1, Line 134: ffs
...
There's no such function here. Please remove the comment.
Ack
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59738
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib458abfec7e03b2979569a8440a6e69b0285ac32
Gerrit-Change-Number: 59738
Gerrit-PatchSet: 2
Gerrit-Owner: Jianjun Wang jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Jianjun Wang jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Dec 2021 08:14:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com
Gerrit-MessageType: comment