[M] Change in coreboot[main]: drivers/amd/opensil/romstage.c: Implement cbmem_top_chipset in driver - coreboot-gerrit

19 Dec 2024


      Attention is currently required from: Felix Held, Nick Kochlowski.
Martin Roth has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85635?usp=email )
Change subject: drivers/amd/opensil/romstage.c: Implement cbmem_top_chipset in driver
......................................................................
Patch Set 6:
(1 comment)
File src/drivers/amd/opensil/romstage.c:
https://review.coreboot.org/c/coreboot/+/85635/comment/34b43418_45587e2e?usp... :
PS6, Line 13: size so
I know this was just moved, but it doesn't make sense. Should this be "size, so" or "size to"?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85635?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibc79456b0429cdd3d8e3fa5c224799a05add8359
Gerrit-Change-Number: 85635
Gerrit-PatchSet: 6
Gerrit-Owner: Nick Kochlowski nickkochlowski@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Nick Kochlowski nickkochlowski@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 19 Dec 2024 17:09:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No