Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32674 )
Change subject: mb/google/poppy/variants/rammus: Support new onboard Hynix memory
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32674/1/src/mainboard/google/poppy/spd/hynix...
File src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNCLGALAR-NVD.spd.hex:
https://review.coreboot.org/#/c/32674/1/src/mainboard/google/poppy/spd/hynix...
PS1, Line 17:
Do we need this last extra empty line, if not, please remove it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32674
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd02953d0c6ac62fa4d7751fd8b103b74433aa73
Gerrit-Change-Number: 32674
Gerrit-PatchSet: 1
Gerrit-Owner: YanRu Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: YanRu Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Thu, 09 May 2019 15:26:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment