Change in coreboot[master]: mb/google/nightfury: Set internal pull-down for GPP_D19

[shkim (Code Review)]

Hello SH Kim,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/46816

to review the following change.

Change subject: mb/google/nightfury: Set internal pull-down for GPP_D19
......................................................................

mb/google/nightfury: Set internal pull-down for GPP_D19

Add internal pull-down for GPP_D19 to improve DMIC noise issue on
nightfury.

BUG=b:171669255
BRANCH=firmware-hatch-12672.B
TEST=Built and checked GPP_D19 voltage after booting

Change-Id: Ie63f260be3d6a55f91908db59312b3b0a8af98f4
Signed-off-by: Seunghwan Kim 
---
M src/mainboard/google/hatch/variants/nightfury/gpio.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/46816/1

diff --git a/src/mainboard/google/hatch/variants/nightfury/gpio.c b/src/mainboard/google/hatch/variants/nightfury/gpio.c
index 951723e..eb6217d 100644
--- a/src/mainboard/google/hatch/variants/nightfury/gpio.c
+++ b/src/mainboard/google/hatch/variants/nightfury/gpio.c
@@ -37,6 +37,8 @@

/* D16 : TOUCHSCREEN_INT_L */
    PAD_CFG_GPI_APIC(GPP_D16, NONE, PLTRST, LEVEL, INVERT),
+	/* D19 : DMIC_CLK_0_SNDW4_CLK */
+	PAD_CFG_NF(GPP_D19, DN_20K, DEEP, NF1),

/* E4  : M2_SSD_PE_WAKE_ODL ==> NC */
    PAD_NC(GPP_E4, NONE),

[Bob Moragues (Code Review)]

Bob Moragues has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46816 )

Change subject: mb/google/nightfury: Set internal pull-down for GPP_D19
......................................................................

Patch Set 1: Code-Review+1

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46816 )

Change subject: mb/google/nightfury: Set internal pull-down for GPP_D19
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46816 )

Change subject: mb/google/nightfury: Set internal pull-down for GPP_D19
......................................................................

mb/google/nightfury: Set internal pull-down for GPP_D19

Add internal pull-down for GPP_D19 to improve DMIC noise issue on
nightfury.

BUG=b:171669255
BRANCH=firmware-hatch-12672.B
TEST=Built and checked GPP_D19 voltage after booting

Change-Id: Ie63f260be3d6a55f91908db59312b3b0a8af98f4
Signed-off-by: Seunghwan Kim 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46816
Tested-by: build bot (Jenkins) 
Reviewed-by: Bob Moragues 
Reviewed-by: Tim Wawrzynczak 
---
M src/mainboard/google/hatch/variants/nightfury/gpio.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved
  Bob Moragues: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/hatch/variants/nightfury/gpio.c b/src/mainboard/google/hatch/variants/nightfury/gpio.c
index 951723e..eb6217d 100644
--- a/src/mainboard/google/hatch/variants/nightfury/gpio.c
+++ b/src/mainboard/google/hatch/variants/nightfury/gpio.c
@@ -37,6 +37,8 @@

/* D16 : TOUCHSCREEN_INT_L */
    PAD_CFG_GPI_APIC(GPP_D16, NONE, PLTRST, LEVEL, INVERT),
+	/* D19 : DMIC_CLK_0_SNDW4_CLK */
+	PAD_CFG_NF(GPP_D19, DN_20K, DEEP, NF1),

/* E4  : M2_SSD_PE_WAKE_ODL ==> NC */
    PAD_NC(GPP_E4, NONE),