Attention is currently required from: Michał Żygowski, Michał Kopeć.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68944 )
Change subject: soc/intel/common/block/oc_wdt: Add OC watchdog common block ......................................................................
Patch Set 3:
(5 comments)
File src/soc/intel/common/block/oc_wdt/oc_wdt.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164017): https://review.coreboot.org/c/coreboot/+/68944/comment/2bb77856_b76885fd PS3, Line 66: readback = inl(PCH_OC_WDT_CTL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164017): https://review.coreboot.org/c/coreboot/+/68944/comment/06ae8ae9_6fc2ba50 PS3, Line 66: readback = inl(PCH_OC_WDT_CTL); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164017): https://review.coreboot.org/c/coreboot/+/68944/comment/b9da85a6_2dfaec7b PS3, Line 66: readback = inl(PCH_OC_WDT_CTL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164017): https://review.coreboot.org/c/coreboot/+/68944/comment/e9803e38_940b2821 PS3, Line 81: printk (BIOS_ERR, "Watchdog: Failure detected\n"); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164017): https://review.coreboot.org/c/coreboot/+/68944/comment/f6b2b847_dcf532ad PS3, Line 192: printk (BIOS_ERR, "Watchdog: timer expiration detected.\n"); space prohibited between function name and open parenthesis '('