[S] Change in coreboot[master]: soc/intel/xeon_sp/spr: Default to X2APIC support

[Johnny Lin (Code Review)]

Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Christian Walter, Tim Chu.

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74184 )

Change subject: soc/intel/xeon_sp/spr: Default to X2APIC support
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1: 
With or without setting x2apic to 1 in devicetree.cb, my AC will see LinuxBoot kernel panic, maybe add this under mainboard?
APIC: Switch to symmetric I/O mode setup
Switched APIC routing to physical flat.
------------[ cut here ]------------
kernel BUG at arch/x86/kernel/apic/apic.c:1588!
invalid opcode: 0000 [#1] SMP NOPTI
CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.10.50 #3
Hardware name: Intel Archer City CRB/Archer City CRB, BIOS 4.19-1079-g696228fa65-dirty 04/04/2023
RIP: 0010:setup_local_APIC+0x68/0x245
Code: e3 fb ff ff bf f0 00 00 00 80 e4 fe 89 c6 e8 e4 fb ff ff 48 8b 05 02 71 b9 00 48 8b 80 a0 00 00 00 e8 56 f2 7c 00 85 c00
RSP: 0000:ffffffff8de03e78 EFLAGS: 00010246
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00000000ffffbfff
RDX: 0000000000000000 RSI: 00000000fffffeff RDI: 0000000000000020
RBP: 0000000000000000 R08: 0000000000000000 R09: 00000000ffffbfff
R10: ffffffff8de03d38 R11: ffffffff8de03d30 R12: ffffffff8e030920
R13: ffffffff8e037ae0 R14: ff24e82d234b0680 R15: 0000000000000000
FS:  0000000000000000(0000) GS:ff24e82d20a00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ff24e82cf9401000 CR3: 0000000038a0a001 CR4: 00000000000616b0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe07f0 DR7: 0000000000000400
Call Trace:
 ? printk+0x53/0x6a
 ? apic_intr_mode_init+0xc4/0xe3
 ? x86_late_time_init+0x1b/0x2b
 ? start_kernel+0x47e/0x507
 ? secondary_startup_64_no_verify+0xc2/0xcb
---[ end trace 7240cedd57090ff1 ]---
RIP: 0010:setup_local_APIC+0x68/0x245
Code: e3 fb ff ff bf f0 00 00 00 80 e4 fe 89 c6 e8 e4 fb ff ff 48 8b 05 02 71 b9 00 48 8b 80 a0 00 00 00 e8 56 f2 7c 00 85 c00
RSP: 0000:ffffffff8de03e78 EFLAGS: 00010246
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00000000ffffbfff
RDX: 0000000000000000 RSI: 00000000fffffeff RDI: 0000000000000020
RBP: 0000000000000000 R08: 0000000000000000 R09: 00000000ffffbfff
R10: ffffffff8de03d38 R11: ffffffff8de03d30 R12: ffffffff8e030920
R13: ffffffff8e037ae0 R14: ff24e82d234b0680 R15: 0000000000000000
FS:  0000000000000000(0000) GS:ff24e82d20a00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ff24e82cf9401000 CR3: 0000000038a0a001 CR4: 00000000000616b0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe07f0 DR7: 0000000000000400
Kernel panic - not syncing: Attempted to kill the idle task!