Andre Heider has posted comments on this change. ( https://review.coreboot.org/23783 )
Change subject: soc/nvidia/tegra210: add missing bl31 params to ATF config ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/23783/3/src/soc/nvidia/tegra210/arm_tf.c File src/soc/nvidia/tegra210/arm_tf.c:
https://review.coreboot.org/#/c/23783/3/src/soc/nvidia/tegra210/arm_tf.c@46 PS3, Line 46: switch (console_uart_get_id()) {
nit: if you just shifted your enum in the other patch by one you wouldn't need this ;)
Hehe yeah, I was thinking about that too. But I want to use those console_uart.h helpers in src/mainboard/ code too, and this ordering (none/invalid<0, first uart=0) felt more natural. But I don't have a strong preference either way, do you want me to change it?
-
Andre Heider (Code Review)