Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70152 )
Change subject: sb/intel/i82801{i,j}x: Use boolean for c{5,6}_enable ......................................................................
sb/intel/i82801{i,j}x: Use boolean for c{5,6}_enable
Change-Id: I1e537d8380ddc918c7d4ab4c4084e582f7aa775d Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M src/mainboard/lenovo/t400/devicetree.cb M src/mainboard/lenovo/x200/devicetree.cb M src/mainboard/roda/rk9/devicetree.cb M src/southbridge/intel/i82801ix/chip.h M src/southbridge/intel/i82801jx/chip.h 5 files changed, 14 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/70152/1
diff --git a/src/mainboard/lenovo/t400/devicetree.cb b/src/mainboard/lenovo/t400/devicetree.cb index 4634c71..5feddce 100644 --- a/src/mainboard/lenovo/t400/devicetree.cb +++ b/src/mainboard/lenovo/t400/devicetree.cb @@ -63,9 +63,6 @@ register "sata_clock_request" = "0" register "sata_traffic_monitor" = "0"
- # Set c-state support - register "c6_enable" = "1" - # Set thermal throttling to 75%. register "throttle_duty" = "THTL_75_0"
diff --git a/src/mainboard/lenovo/x200/devicetree.cb b/src/mainboard/lenovo/x200/devicetree.cb index e0eefe7..b69aba8 100644 --- a/src/mainboard/lenovo/x200/devicetree.cb +++ b/src/mainboard/lenovo/x200/devicetree.cb @@ -62,10 +62,6 @@ register "sata_clock_request" = "0" register "sata_traffic_monitor" = "0"
- # Set c-state support - register "c5_enable" = "1" - register "c6_enable" = "1" - # Set thermal throttling to 75%. register "throttle_duty" = "THTL_75_0"
diff --git a/src/mainboard/roda/rk9/devicetree.cb b/src/mainboard/roda/rk9/devicetree.cb index fbb026b..6bb0654 100644 --- a/src/mainboard/roda/rk9/devicetree.cb +++ b/src/mainboard/roda/rk9/devicetree.cb @@ -50,10 +50,6 @@ register "sata_clock_request" = "0" register "sata_traffic_monitor" = "0"
- # Set c-state support - register "c5_enable" = "1" - register "c6_enable" = "1" - # Set thermal throttling to 75%. register "throttle_duty" = "THTL_75_0"
diff --git a/src/southbridge/intel/i82801ix/chip.h b/src/southbridge/intel/i82801ix/chip.h index 968a81f..d4177cf 100644 --- a/src/southbridge/intel/i82801ix/chip.h +++ b/src/southbridge/intel/i82801ix/chip.h @@ -59,8 +59,8 @@ unsigned int sata_traffic_monitor : 1;
bool c4onc3_enable:true; - unsigned int c5_enable : 1; - unsigned int c6_enable : 1; + bool c5_enable : true; + bool c6_enable : true;
unsigned int throttle_duty : 3;
diff --git a/src/southbridge/intel/i82801jx/chip.h b/src/southbridge/intel/i82801jx/chip.h index e36cce9..0214f40 100644 --- a/src/southbridge/intel/i82801jx/chip.h +++ b/src/southbridge/intel/i82801jx/chip.h @@ -45,8 +45,8 @@ unsigned int sata_clock_request : 1;
bool c4onc3_enable:true; - unsigned int c5_enable : 1; - unsigned int c6_enable : 1; + bool c5_enable : true; + bool c6_enable : true;
unsigned int throttle_duty : 3;