Attention is currently required from: Marshall Dawson, Matt Papageorge, Justin Frodsham, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51197 )
Change subject: [WIP] vc/amd/fsp/cezanne: add platform_descriptors.h
......................................................................
Patch Set 7: Code-Review+1
(5 comments)
File src/vendorcode/amd/fsp/cezanne/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/51197/comment/d4954d90_f1f9b3b2
PS7, Line 15: typedef
Do we need to use typedefs?
https://review.coreboot.org/c/coreboot/+/51197/comment/2e1e61c3_f462eddd
PS7, Line 78: AUX1
Prefix with DDI_?
https://review.coreboot.org/c/coreboot/+/51197/comment/d9c4c500_25cd02cf
PS7, Line 89: HDP1
Same
https://review.coreboot.org/c/coreboot/+/51197/comment/ea71db35_9ce2cee8
PS7, Line 100: DP
I would also prefix these since enums get added to the global namespace.
https://review.coreboot.org/c/coreboot/+/51197/comment/e101b200_d5cab3b2
PS7, Line 179: port_params
What do I put in here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51197
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16f133b270c99c6e060e5bd0c156cbb03293474
Gerrit-Change-Number: 51197
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 29 Mar 2021 19:09:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment