Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/20979 )
Change subject: nb/intel/x4x/raminit: Move dummy reads after JEDEC init ......................................................................
Patch Set 10: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/20979/8/src/northbridge/intel/x4x/r... File src/northbridge/intel/x4x/raminit_ddr23.c:
https://review.coreboot.org/c/coreboot/+/20979/8/src/northbridge/intel/x4x/r... PS8, Line 2163: (ch << 29) | (r * 0x08000000)
FYI: I'm waiting for this to be addressed before I'll give this patch a +2
Done
https://review.coreboot.org/c/coreboot/+/20979/8/src/northbridge/intel/x4x/r... PS8, Line 2164: 0x800000
me too
Done
https://review.coreboot.org/c/coreboot/+/20979/9/src/northbridge/intel/x4x/r... File src/northbridge/intel/x4x/raminit_ddr23.c:
https://review.coreboot.org/c/coreboot/+/20979/9/src/northbridge/intel/x4x/r... PS9, Line 2163: test_address(ch, r) | 0x800000 | (bank << 12)
probably some parenthesis are missing around this statement, so that not only the first element gets […]
Done
-
Felix Held (Code Review)