Patch set 10:Code-Review +2
3 comments:
File src/northbridge/intel/x4x/raminit_ddr23.c:
Patch Set #8, Line 2163: (ch << 29) | (r * 0x08000000)
FYI: I'm waiting for this to be addressed before I'll give this patch a +2
Done
Patch Set #8, Line 2164: 0x800000
me too
Done
File src/northbridge/intel/x4x/raminit_ddr23.c:
Patch Set #9, Line 2163: test_address(ch, r) | 0x800000 | (bank << 12)
probably some parenthesis are missing around this statement, so that not only the first element gets […]
Done
To view, visit change 20979. To unsubscribe, or for help writing mail filters, visit settings.