Change in coreboot[master]: mb/google/volteer/variant/volteer: Turn I2C3 bus freq closer to 400 k...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Johnny Li (Code Review)

8 Oct 2020 8 Oct '20

3:57 a.m.

Johnny Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46143 )

Change subject: mb/google/volteer/variant/volteer: Turn I2C3 bus freq closer to 400 kHz for camera ......................................................................

mb/google/volteer/variant/volteer: Turn I2C3 bus freq closer to 400 kHz for camera

The current I2C3 bus frequency is 341 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C3 to bring the bus frequency closer to 400kHz.

BUG=b:153588771 TEST=Verified that I2C3 frequency is 394kHz.

Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: Ieacfe74cde84bfad3f5e6145045015a8ad9706ea --- M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/46143/1

diff --git a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb index f0cf02d..ec02ec7 100644 --- a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb @@ -36,6 +36,10 @@ }, .i2c[3] = { .speed = I2C_SPEED_FAST, + .speed = I2C_SPEED_FAST, + .scl_lcnt = 153, + .scl_hcnt = 75, + .sda_hold = 36, }, .i2c[5] = { .speed = I2C_SPEED_FAST,

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Johnny Li (Code Review)

8 Oct 8 Oct

4:02 a.m.

Johnny Li has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/46143 )

Change subject: mb/google/volteer/variant/volteer: Turn I2C3 bus freq closer to 400 kHz for camera ......................................................................

mb/google/volteer/variant/volteer: Turn I2C3 bus freq closer to 400 kHz for camera

The current I2C3 bus frequency is 341 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C3 to bring the bus frequency closer to 400kHz.

BUG=b:153588771 TEST=Verified that I2C3 frequency is 394kHz.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/46143/2

Johnny Li (Code Review)

4:24 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer2: Turn I2C3 bus freq closer to 400...

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46143

to look at the new patch set (#4).

Change subject: mb/google/volteer/variants/volteer2: Turn I2C3 bus freq closer to 400 kHz for camera ......................................................................

mb/google/volteer/variants/volteer2: Turn I2C3 bus freq closer to 400 kHz for camera

The current I2C3 bus frequency is 341 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C3 to bring the bus frequency closer to 400kHz.

BUG=b:153588771 TEST=Verified that I2C3 frequency is 394kHz.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/46143/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/46143 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieacfe74cde84bfad3f5e6145045015a8ad9706ea Gerrit-Change-Number: 46143 Gerrit-PatchSet: 4 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-MessageType: newpatchset

Caveh Jalali (Code Review)

12 Oct 12 Oct

11:53 p.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer2: Turn I2C3 bus freq closer to 400...

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46143 )

Change subject: mb/google/volteer/variants/volteer2: Turn I2C3 bus freq closer to 400 kHz for camera ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46143/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46143/4//COMMIT_MSG@7 PS4, Line 7: Turn Tune

Johnny Li (Code Review)

13 Oct 13 Oct

4:45 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer2: Tune I2C3 bus freq closer to 400...

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46143

to look at the new patch set (#5).

Change subject: mb/google/volteer/variants/volteer2: Tune I2C3 bus freq closer to 400 kHz for camera ......................................................................

mb/google/volteer/variants/volteer2: Tune I2C3 bus freq closer to 400 kHz for camera

The current I2C3 bus frequency is 341 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C3 to bring the bus frequency closer to 400kHz.

BUG=b:153588771 TEST=Verified that I2C3 frequency is 394kHz.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/46143/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/46143 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieacfe74cde84bfad3f5e6145045015a8ad9706ea Gerrit-Change-Number: 46143 Gerrit-PatchSet: 5 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-MessageType: newpatchset

Johnny Li (Code Review)

4:45 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer2: Tune I2C3 bus freq closer to 400...

Johnny Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46143 )

Change subject: mb/google/volteer/variants/volteer2: Tune I2C3 bus freq closer to 400 kHz for camera ......................................................................

Patch Set 5:

fix

-- To view, visit https://review.coreboot.org/c/coreboot/+/46143 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieacfe74cde84bfad3f5e6145045015a8ad9706ea Gerrit-Change-Number: 46143 Gerrit-PatchSet: 5 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-Comment-Date: Tue, 13 Oct 2020 02:45:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Johnny Li (Code Review)

5:10 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer2: Tune I2C3 bus freq closer to 400...

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46143

to look at the new patch set (#7).

Change subject: mb/google/volteer/variants/volteer2: Tune I2C3 bus freq closer to 400 kHz for camera ......................................................................

mb/google/volteer/variants/volteer2: Tune I2C3 bus freq closer to 400 kHz for camera

The current I2C3 bus frequency is 341 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C3 to bring the bus frequency closer to 400kHz.

BUG=b:153588771 TEST=Verified that I2C3 frequency is 394kHz.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/46143/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/46143 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieacfe74cde84bfad3f5e6145045015a8ad9706ea Gerrit-Change-Number: 46143 Gerrit-PatchSet: 7 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-MessageType: newpatchset

Johnny Li (Code Review)

5:25 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer2: Tune I2C3 camera bus freq 400 kHz

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46143

to look at the new patch set (#8).

Change subject: mb/google/volteer/variants/volteer2: Tune I2C3 camera bus freq 400 kHz ......................................................................

mb/google/volteer/variants/volteer2: Tune I2C3 camera bus freq 400 kHz

The current I2C3 bus frequency is 341 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C3 to bring the bus frequency closer to 400kHz.

BUG=b:153588771 TEST=Verified that I2C3 frequency is 394kHz.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/46143/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/46143 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieacfe74cde84bfad3f5e6145045015a8ad9706ea Gerrit-Change-Number: 46143 Gerrit-PatchSet: 8 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-MessageType: newpatchset

Johnny Li (Code Review)

28 Oct 28 Oct

7:26 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variants/volteer2: Tune I2C3 camera bus freq 400 kHz

Johnny Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46143 )

Change subject: mb/google/volteer/variants/volteer2: Tune I2C3 camera bus freq 400 kHz ......................................................................

Abandoned

conflict

-- To view, visit https://review.coreboot.org/c/coreboot/+/46143 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieacfe74cde84bfad3f5e6145045015a8ad9706ea Gerrit-Change-Number: 46143 Gerrit-PatchSet: 8 Gerrit-Owner: Johnny Li johnny_li@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com Gerrit-MessageType: abandon

1547

days inactive

1567

days old

coreboot-gerrit@coreboot.org

8 comments

2 participants

tags (0)

participants (2)

Caveh Jalali (Code Review)
Johnny Li (Code Review)