Attention is currently required from: Nick Vaccaro, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57345 )
Change subject: driver/intel/pmc_mux/conn: add conn_get_type_c_list() ......................................................................
Patch Set 3:
(1 comment)
File src/drivers/intel/pmc_mux/conn/conn.c:
https://review.coreboot.org/c/coreboot/+/57345/comment/6e19dbed_1624fb8e PS3, Line 111: pmc = pcidev_path_on_root(PCH_DEVFN_PMC); : if (!pmc || !pmc->link_list->children) { : printk(BIOS_ERR, "%s: unable to find PMC device or its mux\n", __func__); : return NULL; : } : I kinda think the PMC device should be passed in to this function instead, so that `drivers` doesn't have to worry about any SoC specific things here. This function mostly exists because this file has direct knowledge of `drivers_intel_pmc_mux_conn_ops`, and I'd like to avoid sprinkling the `extern drivers_....ops` more and just switch to functions like this intead 😊