Attention is currently required from: Nick Vaccaro, Patrick Rudolph.

View Change

1 comment:

• File src/drivers/intel/pmc_mux/conn/conn.c:

  • Patch Set #3, Line 111:

    	pmc = pcidev_path_on_root(PCH_DEVFN_PMC);
    	if (!pmc || !pmc->link_list->children) {
    		printk(BIOS_ERR, "%s: unable to find PMC device or its mux\n", __func__);
    		return NULL;
    	}
    
    

    I kinda think the PMC device should be passed in to this function instead, so that `drivers` doesn't have to worry about any SoC specific things here. This function mostly exists because this file has direct knowledge of `drivers_intel_pmc_mux_conn_ops`, and I'd like to avoid sprinkling the `extern drivers_....ops` more and just switch to functions like this intead 😊

To view, visit change 57345. To unsubscribe, or for help writing mail filters, visit settings.