Attention is currently required from: Star Labs.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52796 )
Change subject: src/intel: Add LOCKDIS to mark SPI as writable in SKL
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
To clarify, it's just the BIOS Control register - the SPI is indeed writable. […]
that's indeed strange, but all platforms use the same code to lock the BC register. I guess there's simply no code that sets sane defaults in BC register prior to locking it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I712972428dd22373d8655ce72d36c0957ee9a900
Gerrit-Change-Number: 52796
Gerrit-PatchSet: 4
Gerrit-Owner: Star Labs
admin@starlabs.systems
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Star Labs
admin@starlabs.systems
Gerrit-Comment-Date: Fri, 07 May 2021 16:41:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Star Labs
admin@starlabs.systems
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment