[M] Change in coreboot[master]: soc/intel/cmd/blk/cse: Implement APIs to access FW versions in CMOS

[Subrata Banik (Code Review)]

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Sridhar Siricilla.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74995?usp=email )

Change subject: soc/intel/cmd/blk/cse: Implement APIs to access FW versions in CMOS
......................................................................

Patch Set 36:

(8 comments)

File src/soc/intel/common/block/cse/Kconfig:

https://review.coreboot.org/c/coreboot/+/74995/comment/beebeb12_951ff662 :
PS36, Line 48: SOC_INTEL_PARTITION_FW_CMOS_OFFSET
SOC_INTEL_CSE_FW_PARTITION_CMOS_OFFSET ?

https://review.coreboot.org/c/coreboot/+/74995/comment/567b0b24_a0a32494 :
PS36, Line 53: firmware partition
may be worth clarifying that its the CSE FW partition

File src/soc/intel/common/block/cse/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/74995/comment/efd1b36f_97021189 :
PS36, Line 12: 
i don't think any other changes are necessary here apart from adding cse_lite_cmos.c file

File src/soc/intel/common/block/cse/cse_lite_cmos.c:

https://review.coreboot.org/c/coreboot/+/74995/comment/05c02fc2_75d44bdd :
PS36, Line 8: 0x46575054
it has to be opposite as little endian

https://review.coreboot.org/c/coreboot/+/74995/comment/f0b650fa_8ba01a03 :
PS36, Line 100: get_cmos_cse_version
get_cmos_cse_rw_fw_version

https://review.coreboot.org/c/coreboot/+/74995/comment/9fe9c87a_b4eb66ac :
PS36, Line 114: set_cmos_cse_version
same

https://review.coreboot.org/c/coreboot/+/74995/comment/fc83b66a_ca88dca6 :
PS36, Line 134: 	printk(BIOS_WARNING, "CMOS fw version corrupted, initiating memory re-init\n");
we don't need this IMO

https://review.coreboot.org/c/coreboot/+/74995/comment/c31d8068_5694053a :
PS36, Line 146: printk(BIOS_WARNING, "CMOS fw version corrupted, initiating memory re-init\n");
we don't need this