[M] Change in coreboot[master]: vendorcode/mediatek/mt8192: Fix set but unused variables - coreboot-gerrit

21 Apr 2023


      Attention is currently required from: Xi Chen, Paul Menzel, Arthur Heymans.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74544 )
Change subject: vendorcode/mediatek/mt8192: Fix set but unused variables
......................................................................
Patch Set 5:
(2 comments)
File src/vendorcode/mediatek/mt8192/dramc/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/74544/comment/3569cce0_51616357 
PS5, Line 3017: 
Blank line can be removed.
https://review.coreboot.org/c/coreboot/+/74544/comment/ac6c82d6_0d4b5310 
PS5, Line 3109: ca_ui_default
Why not just remove this variable?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74544
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45d51d53f991556cedd1cc45997d76fc828bceb5
Gerrit-Change-Number: 74544
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com
Gerrit-Reviewer: Xixi Chen xixi.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Xi Chen xixi.chen@mediatek.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 21 Apr 2023 02:52:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment