Change in coreboot[master]: mb/hp/z220_series: Add Z220 CMT Workstation variant - coreboot-gerrit

15 Apr 2022


      Attention is currently required from: Damien Zammit.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62809 )
Change subject: mb/hp/z220_series: Add Z220 CMT Workstation variant
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
File src/mainboard/hp/z220_series/variants/z220_cmt_workstation/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62809/comment/897bbb01_5f6422c1 
PS3, Line 5: 		subsystemid 0x103c 0x1791 inherit
...
No, I think without this line, the whole southbridge has the wrong subsystemid because the missing l […]
Hmmm, you can look at the generated static.c to see what happens.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62809
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b298921e6f509440ec7b049e086c0878f708bd3
Gerrit-Change-Number: 62809
Gerrit-PatchSet: 8
Gerrit-Owner: Damien Zammit
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Damien Zammit
Gerrit-Comment-Date: Fri, 15 Apr 2022 08:10:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Damien Zammit
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment