Attention is currently required from: Michał Żygowski, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59523 )
Change subject: nb/intel/sandybridge/romstage.c: Configure DPR and initialize TXT ......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/intel/sandybridge/romstage.c:
https://review.coreboot.org/c/coreboot/+/59523/comment/e2856bff_05093747 PS2, Line 78: #if CONFIG(INTEL_TXT)
What about compiling the TXT romstage part always?
There's no need to do so. Please use a regular C check and let the compiler optimize out the unreachable code, like I did on Haswell: https://review.coreboot.org/c/coreboot/+/46608/7/src/northbridge/intel/haswe...
Then we could get rid of redundant MSR writing.
I'm afraid I don't follow. The only redundant MSR writing I see is the one CB:59521 adds. That MSR needs to be written even if TXT is not supported.