Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43330 )
Change subject: soc/amd/picasso: Add missing include to smi.h ......................................................................
soc/amd/picasso: Add missing include to smi.h
BUG=b:154756391 TEST=Don't see build failure.
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I36b81643c29ec1e7978d521206fbc366060ab286 --- M src/soc/amd/picasso/include/soc/smi.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/43330/1
diff --git a/src/soc/amd/picasso/include/soc/smi.h b/src/soc/amd/picasso/include/soc/smi.h index 02a23f5..d66f093 100644 --- a/src/soc/amd/picasso/include/soc/smi.h +++ b/src/soc/amd/picasso/include/soc/smi.h @@ -3,6 +3,7 @@ #ifndef __SOUTHBRIDGE_AMD_PI_PICASSO_SMI_H__ #define __SOUTHBRIDGE_AMD_PI_PICASSO_SMI_H__
+#include <stdint.h>
#define SMI_GEVENTS 24 #define SCIMAPS 58
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43330 )
Change subject: soc/amd/picasso: Add missing include to smi.h ......................................................................
Patch Set 1: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43330 )
Change subject: soc/amd/picasso: Add missing include to smi.h ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43330/1/src/soc/amd/picasso/include... File src/soc/amd/picasso/include/soc/smi.h:
https://review.coreboot.org/c/coreboot/+/43330/1/src/soc/amd/picasso/include... PS1, Line 221: size_t <stddef.h>
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43330 )
Change subject: soc/amd/picasso: Add missing include to smi.h ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43330/1/src/soc/amd/picasso/include... File src/soc/amd/picasso/include/soc/smi.h:
https://review.coreboot.org/c/coreboot/+/43330/1/src/soc/amd/picasso/include... PS1, Line 221: size_t
<stddef. […]
Ya. we should also just be able to #include <types.h> for handle all those.
Hello build bot (Jenkins), Furquan Shaikh, Aaron Durbin, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43330
to look at the new patch set (#2).
Change subject: soc/amd/picasso: Add missing include to smi.h ......................................................................
soc/amd/picasso: Add missing include to smi.h
BUG=b:154756391 TEST=Don't see build failure.
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I36b81643c29ec1e7978d521206fbc366060ab286 --- M src/soc/amd/picasso/include/soc/smi.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/43330/2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43330 )
Change subject: soc/amd/picasso: Add missing include to smi.h ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43330/1/src/soc/amd/picasso/include... File src/soc/amd/picasso/include/soc/smi.h:
https://review.coreboot.org/c/coreboot/+/43330/1/src/soc/amd/picasso/include... PS1, Line 221: size_t
Ya. we should also just be able to #include <types.h> for handle all those.
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43330 )
Change subject: soc/amd/picasso: Add missing include to smi.h ......................................................................
Patch Set 2: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43330 )
Change subject: soc/amd/picasso: Add missing include to smi.h ......................................................................
Patch Set 2: Code-Review+2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43330 )
Change subject: soc/amd/picasso: Add missing include to smi.h ......................................................................
Patch Set 3: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43330 )
Change subject: soc/amd/picasso: Add missing include to smi.h ......................................................................
Patch Set 3: Code-Review+2
HAOUAS Elyes has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/43330 )
Change subject: soc/amd/picasso: Add missing include to smi.h ......................................................................
Removed Code-Review+2 by HAOUAS Elyes ehaouas@noos.fr
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43330 )
Change subject: soc/amd/picasso: Add missing include to smi.h ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43330 )
Change subject: soc/amd/picasso: Add missing include to smi.h ......................................................................
Patch Set 3: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43330 )
Change subject: soc/amd/picasso: Add missing include to smi.h ......................................................................
soc/amd/picasso: Add missing include to smi.h
BUG=b:154756391 TEST=Don't see build failure.
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I36b81643c29ec1e7978d521206fbc366060ab286 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43330 Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/include/soc/smi.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Felix Held: Looks good to me, approved Furquan Shaikh: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/amd/picasso/include/soc/smi.h b/src/soc/amd/picasso/include/soc/smi.h index 02a23f5..a629fc5 100644 --- a/src/soc/amd/picasso/include/soc/smi.h +++ b/src/soc/amd/picasso/include/soc/smi.h @@ -3,6 +3,7 @@ #ifndef __SOUTHBRIDGE_AMD_PI_PICASSO_SMI_H__ #define __SOUTHBRIDGE_AMD_PI_PICASSO_SMI_H__
+#include <types.h>
#define SMI_GEVENTS 24 #define SCIMAPS 58
-
Aaron Durbin (Code Review) -
Angel Pons (Code Review)
-
Felix Held (Code Review)
-
Furquan Shaikh (Code Review)
-
HAOUAS Elyes (Code Review)
-
Raul Rangel (Code Review)