Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22850 )
Change subject: fix src/soc/amd/common/agesawrapper_call.h ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/22850/1/src/soc/amd/common/block/pi/amd_late... File src/soc/amd/common/block/pi/amd_late_init.c:
https://review.coreboot.org/#/c/22850/1/src/soc/amd/common/block/pi/amd_late... PS1, Line 31:
Instead of adding the printks, this could have just been changed to:
No reason at all, and I actually did not delete it. I just thought that for someone reading it, having it fully expanded was clearer than do_agesawrapper() which would require the person to search the function and see that it expanded into 2 prints and one AGESA call.
-
Richard Spiegel (Code Review)