Attention is currently required from: Erik van den Bogaert, Frans Hendriks, Matt DeVillier, Michał Żygowski, Piotr Król.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78743?usp=email )
Change subject: soc/intel/braswell: Unify DPTF enablement
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/cyan/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/78743/comment/089d4e34_9068a413 :
PS2, Line 98: off
strago is currently set to on / I didn't change it, just corrected the comment to make it consistent with other BSW boards.
Right. my bad.
cyan I had previously intentionally disabled, but missed that it was being overridden by the FSP UPD, so I was setting the intended behavior. If you'd prefer I set it on here and disable in a follow-on patch to make that more clear, I'm happy to do so
If it's intentional, then it's fine. Just mention it in the commit message, please,
maybe reference the commit for the reason.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78743?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8fc1b63eda0dc2e047d9cb1e11a02d41ab8b2ad7
Gerrit-Change-Number: 78743
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Wed, 01 Nov 2023 14:26:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment