Attention is currently required from: Name of user not set #1004033, Paul Menzel, Stefan Ott.
Martin L Roth has posted comments on this change by Name of user not set #1004033. ( https://review.coreboot.org/c/coreboot/+/60011?usp=email )
Change subject: mb/asus/p5qc: Add ASUS P5Q-E as a variant
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60011/comment/72d07b72_a1aec5cd?usp... :
PS1, Line 10: yhaenggi
It’d be great if you added your full name here.
To get this moving, we're going to ignore this issue.
File src/mainboard/asus/p5qc/variants/p5q_e/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/60011/comment/5a78cbad_4d5526f6?usp... :
PS1, Line 100: SMbus
SMBus
This is minor and can be fixed in a follow-on patch if desired.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60011?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3e8415fe88a421c529308279381aa62e2160e171
Gerrit-Change-Number: 60011
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1004033
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Stefan Ott
coreboot@desire.ch
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Ott
coreboot@desire.ch
Gerrit-Attention: Name of user not set #1004033
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 06 Nov 2024 18:44:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org