[M] Change in coreboot[main]: superio/ite: Add special fan vectors and further options - coreboot-gerrit

25 Mar 2024


      Attention is currently required from: Joel Linn, Nico Huber.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81426?usp=email )
Change subject: superio/ite: Add special fan vectors and further options
......................................................................
Patch Set 4:
(1 comment)
File src/superio/ite/common/env_ctrl.c:
https://review.coreboot.org/c/coreboot/+/81426/comment/954bf4fa_ce2996c5 :
PS1, Line 369: #endif
...
tl;dr I think you'd just have to free the API from the problematic index. […]
I still think keeping ITE_EC_FAN_VECTOR_CNT fixed at 2 and letting the preprocessor exclude the loop via Kconfig is the least-worst option here
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/81426?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I93df2b5652fc3fde775b6161fa5bebc4a34d5e94
Gerrit-Change-Number: 81426
Gerrit-PatchSet: 4
Gerrit-Owner: Joel Linn jl_coreboot@conductive.de
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Joel Linn jl_coreboot@conductive.de
Gerrit-Comment-Date: Mon, 25 Mar 2024 16:51:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com
Comment-In-Reply-To: Joel Linn jl_coreboot@conductive.de
Gerrit-MessageType: comment