Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33949
Change subject: util/nvramtool: Enable -Wmissing-prototypes ......................................................................
util/nvramtool: Enable -Wmissing-prototypes
Change-Id: Id751250b07a495dc25293ff703602bfefa9011bd Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M util/nvramtool/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/33949/1
diff --git a/util/nvramtool/Makefile b/util/nvramtool/Makefile index f5a4fd5..46297a2 100644 --- a/util/nvramtool/Makefile +++ b/util/nvramtool/Makefile @@ -19,7 +19,7 @@ CC = gcc INSTALL = /usr/bin/env install PREFIX = /usr/local -CFLAGS = -O2 -g -Wall -W -I. -DCMOS_HAL=1 +CFLAGS = -O2 -g -Wall -W -Wmissing-prototypes -I. -DCMOS_HAL=1 #CFLAGS = -Os -Wall
CLI_OBJS = cli/nvramtool.o cli/opts.o
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33949 )
Change subject: util/nvramtool: Enable -Wmissing-prototypes ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/33949/1/util/nvramtool/Makefile File util/nvramtool/Makefile:
https://review.coreboot.org/#/c/33949/1/util/nvramtool/Makefile@a23 PS1, Line 23: (out of topic) don't know why we have this
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33949 )
Change subject: util/nvramtool: Enable -Wmissing-prototypes ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33949/1/util/nvramtool/Makefile File util/nvramtool/Makefile:
https://review.coreboot.org/#/c/33949/1/util/nvramtool/Makefile@a23 PS1, Line 23:
(out of topic) […]
Could probably be removed
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33949 )
Change subject: util/nvramtool: Enable -Wmissing-prototypes ......................................................................
util/nvramtool: Enable -Wmissing-prototypes
Change-Id: Id751250b07a495dc25293ff703602bfefa9011bd Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/33949 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M util/nvramtool/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/util/nvramtool/Makefile b/util/nvramtool/Makefile index f5a4fd5..46297a2 100644 --- a/util/nvramtool/Makefile +++ b/util/nvramtool/Makefile @@ -19,7 +19,7 @@ CC = gcc INSTALL = /usr/bin/env install PREFIX = /usr/local -CFLAGS = -O2 -g -Wall -W -I. -DCMOS_HAL=1 +CFLAGS = -O2 -g -Wall -W -Wmissing-prototypes -I. -DCMOS_HAL=1 #CFLAGS = -Os -Wall
CLI_OBJS = cli/nvramtool.o cli/opts.o