Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29480 )
Change subject: mb/kontron/bsl6: Add new Skylake COMe module
......................................................................
Patch Set 31:
(1 comment)
https://review.coreboot.org/c/coreboot/+/29480/27/src/mainboard/kontron/bsl6...
File src/mainboard/kontron/bsl6/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/29480/27/src/mainboard/kontron/bsl6...
PS27, Line 122: device pci 08.0 on end # Gaussian Mixture Model
*poke*
There is no devicetree option for GmmEnable. It is set by SoC code.
chip.c
```
dev = pcidev_path_on_root(SA_DEVFN_GMM);
params->GmmEnable = dev ? dev->enabled : 0;
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29480
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2b6a3f1e9dd095463f1f1521068b9f66a9189c5
Gerrit-Change-Number: 29480
Gerrit-PatchSet: 31
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 Apr 2020 12:30:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment