Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29480 )
Change subject: mb/kontron/bsl6: Add new Skylake COMe module ......................................................................
Patch Set 31:
(3 comments)
https://review.coreboot.org/c/coreboot/+/29480/24//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/29480/24//COMMIT_MSG@11 PS24, Line 11:
Tested how? Payload and OS?
*poke*
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6... File src/mainboard/kontron/bsl6/Kconfig:
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6... PS29, Line 46: config CBFS_SIZE : hex : default 0x600000
In the best case, it shifts convenience from one use case to another. In the worst […]
Done
https://review.coreboot.org/c/coreboot/+/29480/27/src/mainboard/kontron/bsl6... File src/mainboard/kontron/bsl6/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/29480/27/src/mainboard/kontron/bsl6... PS27, Line 122: device pci 08.0 on end # Gaussian Mixture Model
It depends on GmmEnable being set.
*poke*