Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45719 )
Change subject: sb/intel/lynxpoint/acpi/serialio.asl: Enable DMA channels ......................................................................
sb/intel/lynxpoint/acpi/serialio.asl: Enable DMA channels
Broadwell does this, so do it on Lynx Point too.
Change-Id: I309f0cbf93e3f75b20cdd049d9437841ef61c03a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/lynxpoint/acpi/serialio.asl 1 file changed, 8 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/45719/1
diff --git a/src/southbridge/intel/lynxpoint/acpi/serialio.asl b/src/southbridge/intel/lynxpoint/acpi/serialio.asl index 7acd30d..8956563 100644 --- a/src/southbridge/intel/lynxpoint/acpi/serialio.asl +++ b/src/southbridge/intel/lynxpoint/acpi/serialio.asl @@ -162,9 +162,8 @@ // DMA channels are only used if Serial IO DMA controller is enabled Name (DBUF, ResourceTemplate () { - // TODO: Need to update IASL to support FixedDMA - //FixedDMA (0x18, 4, Width32Bit, DMA1) // Tx - //FixedDMA (0x19, 5, Width32Bit, DMA2) // Rx + FixedDMA (0x18, 4, Width32Bit, DMA1) // Tx + FixedDMA (0x19, 5, Width32Bit, DMA2) // Rx })
Method (_CRS, 0, NotSerialized) @@ -243,9 +242,8 @@ // DMA channels are only used if Serial IO DMA controller is enabled Name (DBUF, ResourceTemplate () { - // TODO: Need to update IASL to support FixedDMA - //FixedDMA (0x1A, 6, Width32Bit, DMA1) // Tx - //FixedDMA (0x1B, 7, Width32Bit, DMA2) // Rx + FixedDMA (0x1A, 6, Width32Bit, DMA1) // Tx + FixedDMA (0x1B, 7, Width32Bit, DMA2) // Rx })
Method (_CRS, 0, NotSerialized) @@ -358,9 +356,8 @@ // DMA channels are only used if Serial IO DMA controller is enabled Name (DBUF, ResourceTemplate () { - // TODO: Need to update IASL to support FixedDMA - //FixedDMA (0x10, 0, Width32Bit, DMA1) // Tx - //FixedDMA (0x11, 1, Width32Bit, DMA2) // Rx + FixedDMA (0x10, 0, Width32Bit, DMA1) // Tx + FixedDMA (0x11, 1, Width32Bit, DMA2) // Rx })
Method (_CRS, 0, NotSerialized) @@ -408,9 +405,8 @@ // DMA channels are only used if Serial IO DMA controller is enabled Name (DBUF, ResourceTemplate () { - // TODO: Need to update IASL to support FixedDMA - //FixedDMA (0x16, 2, Width32Bit, DMA1) // Tx - //FixedDMA (0x17, 3, Width32Bit, DMA2) // Rx + FixedDMA (0x16, 2, Width32Bit, DMA1) // Tx + FixedDMA (0x17, 3, Width32Bit, DMA2) // Rx })
Method (_CRS, 0, NotSerialized)
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45719 )
Change subject: sb/intel/lynxpoint/acpi/serialio.asl: Enable DMA channels ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45719/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45719/1//COMMIT_MSG@9 PS1, Line 9: Broadwell does this, so do it on Lynx Point too. Broadwell and Lynx Point are same ?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45719 )
Change subject: sb/intel/lynxpoint/acpi/serialio.asl: Enable DMA channels ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45719/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45719/1//COMMIT_MSG@9 PS1, Line 9: Broadwell does this, so do it on Lynx Point too.
Broadwell and Lynx Point are same ?
No, but the Broadwell code is meant to support Haswell LP as well. And Lynx Point is the PCH for Haswell. Only Lynx Point LP has Serial I/O.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45719 )
Change subject: sb/intel/lynxpoint/acpi/serialio.asl: Enable DMA channels ......................................................................
Patch Set 1: Code-Review+2
doesn't appear to break serial IO devices on google/slippy variants (touchpad, touchscreen) under Linux or Windows
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45719 )
Change subject: sb/intel/lynxpoint/acpi/serialio.asl: Enable DMA channels ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45719/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45719/1//COMMIT_MSG@9 PS1, Line 9: Broadwell does this, so do it on Lynx Point too.
No, but the Broadwell code is meant to support Haswell LP as well. […]
Ack
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45719 )
Change subject: sb/intel/lynxpoint/acpi/serialio.asl: Enable DMA channels ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
doesn't appear to break serial IO devices on google/slippy variants (touchpad, touchscreen) under Linux or Windows
Thanks for testing!
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45719 )
Change subject: sb/intel/lynxpoint/acpi/serialio.asl: Enable DMA channels ......................................................................
sb/intel/lynxpoint/acpi/serialio.asl: Enable DMA channels
Broadwell does this, so do it on Lynx Point too.
Change-Id: I309f0cbf93e3f75b20cdd049d9437841ef61c03a Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45719 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/southbridge/intel/lynxpoint/acpi/serialio.asl 1 file changed, 8 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/southbridge/intel/lynxpoint/acpi/serialio.asl b/src/southbridge/intel/lynxpoint/acpi/serialio.asl index 83bc6eb..ce3a869 100644 --- a/src/southbridge/intel/lynxpoint/acpi/serialio.asl +++ b/src/southbridge/intel/lynxpoint/acpi/serialio.asl @@ -162,9 +162,8 @@ // DMA channels are only used if Serial IO DMA controller is enabled Name (DBUF, ResourceTemplate () { - // TODO: Need to update IASL to support FixedDMA - //FixedDMA (0x18, 4, Width32Bit, DMA1) // Tx - //FixedDMA (0x19, 5, Width32Bit, DMA2) // Rx + FixedDMA (0x18, 4, Width32Bit, DMA1) // Tx + FixedDMA (0x19, 5, Width32Bit, DMA2) // Rx })
Method (_CRS, 0, NotSerialized) @@ -243,9 +242,8 @@ // DMA channels are only used if Serial IO DMA controller is enabled Name (DBUF, ResourceTemplate () { - // TODO: Need to update IASL to support FixedDMA - //FixedDMA (0x1A, 6, Width32Bit, DMA1) // Tx - //FixedDMA (0x1B, 7, Width32Bit, DMA2) // Rx + FixedDMA (0x1A, 6, Width32Bit, DMA1) // Tx + FixedDMA (0x1B, 7, Width32Bit, DMA2) // Rx })
Method (_CRS, 0, NotSerialized) @@ -358,9 +356,8 @@ // DMA channels are only used if Serial IO DMA controller is enabled Name (DBUF, ResourceTemplate () { - // TODO: Need to update IASL to support FixedDMA - //FixedDMA (0x10, 0, Width32Bit, DMA1) // Tx - //FixedDMA (0x11, 1, Width32Bit, DMA2) // Rx + FixedDMA (0x10, 0, Width32Bit, DMA1) // Tx + FixedDMA (0x11, 1, Width32Bit, DMA2) // Rx })
Method (_CRS, 0, NotSerialized) @@ -408,9 +405,8 @@ // DMA channels are only used if Serial IO DMA controller is enabled Name (DBUF, ResourceTemplate () { - // TODO: Need to update IASL to support FixedDMA - //FixedDMA (0x16, 2, Width32Bit, DMA1) // Tx - //FixedDMA (0x17, 3, Width32Bit, DMA2) // Rx + FixedDMA (0x16, 2, Width32Bit, DMA1) // Tx + FixedDMA (0x17, 3, Width32Bit, DMA2) // Rx })
Method (_CRS, 0, NotSerialized)
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Matt DeVillier (Code Review)