Attention is currently required from: Furquan Shaikh, Keith Tzeng, Wisley Chen.
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52847 )
Change subject: drivers/i2c/generic: Set S0W to D3hot for wake device
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52847/comment/c5818317_1a0bccfe
PS4, Line 11: The power resource is not turned off.
: Hence, it still is capable of waking.
Can you please rephrase this as follows: […]
Done
Patchset:
PS5:
Please help review.
Thanks
File src/drivers/i2c/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/52847/comment/521cabc4_0ead582a
PS4, Line 101: 3
ACPI_DEVICE_SLEEP_D3_HOT
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52847
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34e4b2350875530d3337be700276bcc4fb1f810a
Gerrit-Change-Number: 52847
Gerrit-PatchSet: 5
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 04 May 2021 06:06:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment