Attention is currently required from: Damien Zammit, Angel Pons, Patrick Rudolph.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50976 )
Change subject: [WIP] CBMEM: Always reset on ACPI S3 resume failures
......................................................................
Patch Set 3:
(2 comments)
File src/include/cbmem.h:
https://review.coreboot.org/c/coreboot/+/50976/comment/bc6ca415_b80dac0b
PS1, Line 52: Returns 0 if old cbmem was recovered.
Function returns nothing.
Yeah, need to decide what to do with tests/lib/imd-cbmem.c.
File src/lib/imd_cbmem.c:
https://review.coreboot.org/c/coreboot/+/50976/comment/a8b94f5c_9c1a2a13
PS1, Line 139: full_reset
Isn't that x86-specific?
It is, and the file is missing the include too for that reason.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50976
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3301a11e494684d1991c919293eb4f2dc335500f
Gerrit-Change-Number: 50976
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 21 Feb 2021 04:19:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment