Attention is currently required from: Patrick Rudolph, Paul Menzel.
Felix Held has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86385?usp=email )
Change subject: device/pci_rom: Keep track of VBIOS ......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3: only had a very brief look at this one
File src/device/pci_rom.c:
https://review.coreboot.org/c/coreboot/+/86385/comment/d0ff6dbe_0ad88253?usp... : PS3, Line 172: #if CONFIG(HAVE_ACPI_TABLES) when removing the guard in the header file, those guards can be dropped too, since this will still build and behave as expected in the !CONFIG(HAVE_ACPI_TABLES) case. same in line 181
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/86385/comment/6968e74b_bbae3060?usp... : PS3, Line 131: #if CONFIG(HAVE_ACPI_TABLES) hmm, i don't see the need to put this in a #if CONFIG(HAVE_ACPI_TABLES) block and iirc i removed some #if CONFIG(HAVE_ACPI_TABLES) instances in this file some time ago