Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19067 )
Change subject: cpu/intel/model_106cx: Add tsc_freq_mhz() function ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19067/1/src/cpu/intel/model_106cx/tsc_freq.c File src/cpu/intel/model_106cx/tsc_freq.c:
PS1, Line 29: 400
From where this value came ? can we use macro for this ?
Mostly a poor copy from src/northbridge/intel/i945/udelay.c
cpu/x86/lapic/apic_timer.c is more correct but what should be done is to rely on MCHBAR(CLKCFG) since sometimes (although probably not on these atoms) northbridge limits freq or BSEL straps are ill configured.