Hello Eric Peers, Rob Barnes,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/39598
to review the following change.
Change subject: util/amdfwtool : Fix file open error msg ......................................................................
util/amdfwtool : Fix file open error msg
Print out the name of the file that failed to open.
BUG=none TEST=rerun build-board.sh with missing files BRANCH=none
Signed-off-by: Eric Peers epeers@google.com Change-Id: Id8543f25ea827fc8764e0315434b834e65bfa7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+... Reviewed-by: Rob Barnes robbarnes@google.com Commit-Queue: Rob Barnes robbarnes@google.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/39598/1
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 5bcc0a7..4f1e8ba 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -575,7 +575,8 @@
fd = open(src_file, O_RDONLY); if (fd < 0) { - printf("Error: %s\n", strerror(errno)); + printf("Error opening file: %s: %s\n", + src_file, strerror(errno)); return -1; }
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39598 )
Change subject: util/amdfwtool : Fix file open error msg ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39598 )
Change subject: util/amdfwtool : Fix file open error msg ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/39598/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39598/1//COMMIT_MSG@7 PS1, Line 7: nit: spurious space?
https://review.coreboot.org/c/coreboot/+/39598/1//COMMIT_MSG@17 PS1, Line 17: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+... Can shorten this: https://chromium-review.googlesource.com/2090667
https://review.coreboot.org/c/coreboot/+/39598/1//COMMIT_MSG@19 PS1, Line 19: Commit-Queue: Rob Barnes robbarnes@google.com Is this tag needed?
Hello build bot (Jenkins), Angel Pons, Rob Barnes, Eric Peers,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39598
to look at the new patch set (#2).
Change subject: util/amdfwtool: Fix file open error msg ......................................................................
util/amdfwtool: Fix file open error msg
Print out the name of the file that failed to open.
BUG=none TEST=rerun build-board.sh with missing files BRANCH=none
Signed-off-by: Eric Peers epeers@google.com Change-Id: Id8543f25ea827fc8764e0315434b834e65bfa7fb Reviewed-on: https://chromium-review.googlesource.com/2090667 Reviewed-by: Rob Barnes robbarnes@google.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/39598/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39598 )
Change subject: util/amdfwtool: Fix file open error msg ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39598/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39598/1//COMMIT_MSG@7 PS1, Line 7:
nit: spurious space?
Done
https://review.coreboot.org/c/coreboot/+/39598/1//COMMIT_MSG@17 PS1, Line 17: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
Can shorten this: https://chromium-review.googlesource. […]
Done
https://review.coreboot.org/c/coreboot/+/39598/1//COMMIT_MSG@19 PS1, Line 19: Commit-Queue: Rob Barnes robbarnes@google.com
Is this tag needed?
Done. No idea what that tag is for though
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39598 )
Change subject: util/amdfwtool: Fix file open error msg ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39598/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39598/1//COMMIT_MSG@19 PS1, Line 19: Commit-Queue: Rob Barnes robbarnes@google.com
Done. […]
It's added by the Commit Queue bot, I think.
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39598 )
Change subject: util/amdfwtool: Fix file open error msg ......................................................................
util/amdfwtool: Fix file open error msg
Print out the name of the file that failed to open.
BUG=none TEST=rerun build-board.sh with missing files BRANCH=none
Signed-off-by: Eric Peers epeers@google.com Change-Id: Id8543f25ea827fc8764e0315434b834e65bfa7fb Reviewed-on: https://chromium-review.googlesource.com/2090667 Reviewed-by: Rob Barnes robbarnes@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39598 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Rob Barnes: Looks good to me, but someone else must approve
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 5bcc0a7..4f1e8ba 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -575,7 +575,8 @@
fd = open(src_file, O_RDONLY); if (fd < 0) { - printf("Error: %s\n", strerror(errno)); + printf("Error opening file: %s: %s\n", + src_file, strerror(errno)); return -1; }
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39598 )
Change subject: util/amdfwtool: Fix file open error msg ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1407 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1406 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1405
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Felix Held (Code Review)
-
Rob Barnes (Code Review)