Attention is currently required from: Martin Roth, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop blob loading changes ......................................................................
Patch Set 16:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/502644eb_3859a1e2 PS16, Line 11: bool aop_fw_entry; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/190dfc44_75756cf0 PS16, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/25faf740_b902a978 PS16, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/0e3e66b9_18d22125 PS16, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/03675054_073fbc0e PS16, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/9da0dbb7_271a9e4b PS16, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/62d59564_39446845 PS16, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/acd10a06_17c4fe6b PS16, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/3ac66ec5_1d4f7428 PS16, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/0357b9a7_276dc357 PS16, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/595143bf_14382b06 PS16, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/dc8aa112_5d496b02 PS16, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/dd36f5c9_3ad48b95 PS16, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/204169ee_f1ff1e5f PS16, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/7619bddd_dc55dfb4 PS16, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/74674e67_bcd6ad6b PS16, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/7253a624_1410cc0e PS16, Line 23: clock_reset_aop(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/0d3ec4a1_15166e54 PS16, Line 23: clock_reset_aop(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/ec511bd3_674f3a1a PS16, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/13682ec1_475e0a72 PS16, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/a1e89317_01630fde PS16, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/aca291aa_8d822cd7 PS16, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/1e38d69e_ecb0d47e PS16, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/9aae28af_172f321a PS16, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/a420a0f6_5b2508d8 PS16, Line 15: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/b4a5c2ac_dfd341a5 PS16, Line 15: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line