Attention is currently required from: Martin Roth, Julius Werner, mturney mturney.

View Change

26 comments:

• File src/soc/qualcomm/sc7280/aop_load_reset.c:

  • Patch Set #16, Line 11: bool aop_fw_entry;

    code indent should use tabs where possible

  • Patch Set #16, Line 11: bool aop_fw_entry;

    please, no spaces at the start of a line

  • Patch Set #16, Line 13: struct prog aop_fw_prog =

    code indent should use tabs where possible

  • Patch Set #16, Line 13: struct prog aop_fw_prog =

    please, no spaces at the start of a line

  • Patch Set #16, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop");

    code indent should use tabs where possible

  • Patch Set #16, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop");

    please, no spaces at the start of a line

  • Patch Set #16, Line 16: if (prog_locate(&aop_fw_prog))

    code indent should use tabs where possible

  • Patch Set #16, Line 16: if (prog_locate(&aop_fw_prog))

    please, no spaces at the start of a line

  • Patch Set #16, Line 17: die("SOC image: AOP_FW not found");

    code indent should use tabs where possible

  • Patch Set #16, Line 17: die("SOC image: AOP_FW not found");

    please, no spaces at the start of a line

  • Patch Set #16, Line 19: aop_fw_entry = selfload(&aop_fw_prog);

    code indent should use tabs where possible

  • Patch Set #16, Line 19: aop_fw_entry = selfload(&aop_fw_prog);

    please, no spaces at the start of a line

  • Patch Set #16, Line 20: if (!aop_fw_entry)

    code indent should use tabs where possible

  • Patch Set #16, Line 20: if (!aop_fw_entry)

    please, no spaces at the start of a line

  • Patch Set #16, Line 21: die("SOC image: AOP load failed");

    code indent should use tabs where possible

  • Patch Set #16, Line 21: die("SOC image: AOP load failed");

    please, no spaces at the start of a line

  • Patch Set #16, Line 23: clock_reset_aop();

    code indent should use tabs where possible

  • Patch Set #16, Line 23: clock_reset_aop();

    please, no spaces at the start of a line

  • Patch Set #16, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n");

    code indent should use tabs where possible

  • Patch Set #16, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n");

    please, no spaces at the start of a line

• File src/soc/qualcomm/sc7280/mmu.c:

  • Patch Set #16, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM);

    code indent should use tabs where possible

  • Patch Set #16, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM);

    please, no spaces at the start of a line

  • Patch Set #16, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM);

    code indent should use tabs where possible

  • Patch Set #16, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM);

    please, no spaces at the start of a line

• File src/soc/qualcomm/sc7280/soc.c:

  • Patch Set #16, Line 15: REGION_SIZE(dram_aop) / KiB);

    code indent should use tabs where possible

  • Patch Set #16, Line 15: REGION_SIZE(dram_aop) / KiB);

    please, no spaces at the start of a line

To view, visit change 49767. To unsubscribe, or for help writing mail filters, visit settings.