Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37126 )
Change subject: makechips.sh: protect version number ......................................................................
makechips.sh: protect version number
Things go wrong if the version number has a space in it right now.
Change-Id: I584c60a6c6c957f775981a900b701455d0742502 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M makechips.sh 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/26/37126/1
diff --git a/makechips.sh b/makechips.sh index aff2301..61d7357 100755 --- a/makechips.sh +++ b/makechips.sh @@ -53,8 +53,8 @@ echo " Creating configs..." mkdir -p $WD/configs cp -a $TEMP/Program\ Files/DediProg/EM100/config/EM100Pro/*.cfg $WD/configs -echo "${VERSION}" > $WD/configs/VERSION -VERSION=${VERSION} $WD/makechips $WD/configs/*.cfg > $WD/em100pro_chips.h +echo -n "${VERSION}" > $WD/configs/VERSION +VERSION="${VERSION}" $WD/makechips $WD/configs/*.cfg > $WD/em100pro_chips.h
echo " Extract firmware files..." mkdir -p $WD/firmware
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37126 )
Change subject: makechips.sh: protect version number ......................................................................
Patch Set 5: Code-Review+2
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/37126 )
Change subject: makechips.sh: protect version number ......................................................................
makechips.sh: protect version number
Things go wrong if the version number has a space in it right now.
Change-Id: I584c60a6c6c957f775981a900b701455d0742502 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-on: https://review.coreboot.org/c/em100/+/37126 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M makechips.sh 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/makechips.sh b/makechips.sh index aff2301..61d7357 100755 --- a/makechips.sh +++ b/makechips.sh @@ -53,8 +53,8 @@ echo " Creating configs..." mkdir -p $WD/configs cp -a $TEMP/Program\ Files/DediProg/EM100/config/EM100Pro/*.cfg $WD/configs -echo "${VERSION}" > $WD/configs/VERSION -VERSION=${VERSION} $WD/makechips $WD/configs/*.cfg > $WD/em100pro_chips.h +echo -n "${VERSION}" > $WD/configs/VERSION +VERSION="${VERSION}" $WD/makechips $WD/configs/*.cfg > $WD/em100pro_chips.h
echo " Extract firmware files..." mkdir -p $WD/firmware
-
Martin Roth (Code Review) -
Stefan Reinauer (Code Review)