Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36440 )
Change subject: Makefile.inc: Consolidate submodule comments ......................................................................
Makefile.inc: Consolidate submodule comments
Reduce duplicated comments explaining that submodules' settings in .gitmodules are update=none, and that --checkout is required. This prepares for another submodule, and makes adding a third set of comments unnecessary.
Change-Id: I7721333a61122284ed9975ecd2adc3271a879728 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M Makefile.inc 1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/36440/1
diff --git a/Makefile.inc b/Makefile.inc index f7f3708..79fc256 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -193,13 +193,11 @@ # try to fetch non-optional submodules if the source is under git forgetthis:=$(if $(GIT),$(shell git submodule update --init)) ifeq ($(CONFIG_USE_BLOBS),y) -# this is necessary because 3rdparty/{blobs,intel-microcode} is update=none, and so is ignored -# unless explicitly requested and enabled through --checkout +# These items are necessary because each has update=none in .gitmodules. They are ignored +# until expressly requested and enabled with --checkout forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/blobs)) forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/intel-microcode)) ifeq ($(CONFIG_PLATFORM_USES_FSP1_0)$(CONFIG_PLATFORM_USES_FSP1_1)$(CONFIG_PLATFORM_USES_FSP2_0),y) -# this is necessary because 3rdparty/fsp is update=none, and so is ignored -# unless explicitly requested and enabled through --checkout forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/fsp)) endif endif
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36440 )
Change subject: Makefile.inc: Consolidate submodule comments ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36440 )
Change subject: Makefile.inc: Consolidate submodule comments ......................................................................
Makefile.inc: Consolidate submodule comments
Reduce duplicated comments explaining that submodules' settings in .gitmodules are update=none, and that --checkout is required. This prepares for another submodule, and makes adding a third set of comments unnecessary.
Change-Id: I7721333a61122284ed9975ecd2adc3271a879728 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36440 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M Makefile.inc 1 file changed, 2 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/Makefile.inc b/Makefile.inc index 04c83d8..3ca113b 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -197,13 +197,11 @@ # try to fetch non-optional submodules if the source is under git forgetthis:=$(if $(GIT),$(shell git submodule update --init)) ifeq ($(CONFIG_USE_BLOBS),y) -# this is necessary because 3rdparty/{blobs,intel-microcode} is update=none, and so is ignored -# unless explicitly requested and enabled through --checkout +# These items are necessary because each has update=none in .gitmodules. They are ignored +# until expressly requested and enabled with --checkout forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/blobs)) forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/intel-microcode)) ifeq ($(CONFIG_PLATFORM_USES_FSP1_0)$(CONFIG_PLATFORM_USES_FSP1_1)$(CONFIG_PLATFORM_USES_FSP2_0),y) -# this is necessary because 3rdparty/fsp is update=none, and so is ignored -# unless explicitly requested and enabled through --checkout forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/fsp)) endif endif
-
Marshall Dawson (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)