Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40474 )
Change subject: device: Add a helper to find device behind a PCI-to-PCI bridge device
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40474/4/src/device/device_const.c
File src/device/device_const.c:
https://review.coreboot.org/c/coreboot/+/40474/4/src/device/device_const.c@2...
PS4, Line 233: link_list
You seem to be looking at it from the downstream side (i.e. the PCI […]
Okay. I have changed to pcidev_path_behind_pci2pci_bridge(). I did not use p2p because it is very close to pnp.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40474
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5672b35cda66431a0f1977f217bdf61d3012ace
Gerrit-Change-Number: 40474
Gerrit-PatchSet: 7
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 19 Apr 2020 19:15:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment