Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55330 )
Change subject: soc/intel/tigerlake: Make use of is_devfn_enabled() function ......................................................................
Patch Set 1: Code-Review+1
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55330/comment/97dc0e01_40583003 PS1, Line 15: built nit: build
https://review.coreboot.org/c/coreboot/+/55330/comment/5e2a2808_ee4f6e6c PS1, Line 17: nit: Drop blank line?
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55330/comment/b127021c_250fb9ea PS1, Line 266: dev->enabled = 0; This also disabled the device in the devicetree
https://review.coreboot.org/c/coreboot/+/55330/comment/856c6e98_dda75558 PS1, Line 345: SA_DEVFN_VMD SA_DEVFN_THC0
https://review.coreboot.org/c/coreboot/+/55330/comment/e6acd84b_4a9b61e8 PS1, Line 346: nit: Drop blank line?
File src/soc/intel/tigerlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55330/comment/55a6976b_9c2fa4f2 PS1, Line 114: nit: Drop blank line?
https://review.coreboot.org/c/coreboot/+/55330/comment/f83e6617_9eb91333 PS1, Line 117: : m_cfg->TcssItbtPcie0En = is_devfn_enabled(SA_DEVFN_TBT0); : : m_cfg->TcssItbtPcie1En = is_devfn_enabled(SA_DEVFN_TBT1); : : m_cfg->TcssItbtPcie2En = is_devfn_enabled(SA_DEVFN_TBT2); : : m_cfg->TcssItbtPcie3En = is_devfn_enabled(SA_DEVFN_TBT3); nit: Drop blank lines in between?