Attention is currently required from: Felix Singer, Kapil Porwal, Meera Ravindranath, Ronak Kanabar, Sridhar Siricilla, Subrata Banik, Tarun Tuli.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75663?usp=email )
Change subject: vendorcode/intel: Add edk2-stable202302 support
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Yeah I see. I just don't like copy&paste. […]
EDK2 submodules (we would need one per needed version) would create a huge
overhead to just build a board with FSP (which are a lot).
There used to be a tool to convert FSP headers to standard C, IIRC. This
way we could avoid edk2 headers altogether. It would create additional work
in other situations, though. For instance, we'd have to re-sync header files
with every FSP submodule update (could be semi-automated though). I guess
the only way to figure out if it would be less noisy in the long run is
to try :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75663?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d4deab0bd1d2c6df28e067894875b80413cd905
Gerrit-Change-Number: 75663
Gerrit-PatchSet: 3
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Wed, 07 Jun 2023 10:29:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment