Change in coreboot[master]: 3rdparty/amd_blobs: update submodule pointer

List overview All Threads
Download

newer

older

Change in libgfxinit[master]:...

Change in coreboot[master]:...

Felix Held (Code Review)

20 Oct 2020 20 Oct '20

4:43 p.m.

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46594 )

Change subject: 3rdparty/amd_blobs: update submodule pointer ......................................................................

3rdparty/amd_blobs: update submodule pointer

This now tracks a recently created upstream repository located at https://github.com/amd/firmware_binaries

BUG=b:166107781

Change-Id: Ib193d646bb51cbf7b86f46828033e619c3f70e16 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M 3rdparty/amd_blobs 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/46594/1

diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs index e393a88..8c668ab 160000 --- a/3rdparty/amd_blobs +++ b/3rdparty/amd_blobs @@ -1 +1 @@ -Subproject commit e393a885c89f8ee3f05242a9e42578c60931b49d +Subproject commit 8c668ab552a02724a07f8c6e7285a5f21a61569b

Attachments:

attachment.htm (text/html — 2.2 KB)

Show replies by date

Patrick Georgi (Code Review)

20 Oct 20 Oct

4:50 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46594 )

Change subject: 3rdparty/amd_blobs: update submodule pointer ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46594 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib193d646bb51cbf7b86f46828033e619c3f70e16 Gerrit-Change-Number: 46594 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Tue, 20 Oct 2020 13:50:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

21 Oct 21 Oct

4:45 p.m.

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46594 )

Change subject: 3rdparty/amd_blobs: update submodule pointer ......................................................................

3rdparty/amd_blobs: update submodule pointer

This now tracks a recently created upstream repository located at https://github.com/amd/firmware_binaries

BUG=b:166107781

Change-Id: Ib193d646bb51cbf7b86f46828033e619c3f70e16 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/46594 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M 3rdparty/amd_blobs 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/46594 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib193d646bb51cbf7b86f46828033e619c3f70e16 Gerrit-Change-Number: 46594 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

8:02 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46594 )

Change subject: 3rdparty/amd_blobs: update submodule pointer ......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 5/1/6 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/24040 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/24039 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/24038 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/24037 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/24035 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/24034

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/46594 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib193d646bb51cbf7b86f46828033e619c3f70e16 Gerrit-Change-Number: 46594 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Wed, 21 Oct 2020 17:02:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

22 Oct 22 Oct

12:57 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46594 )

Change subject: 3rdparty/amd_blobs: update submodule pointer ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46594/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46594/2//COMMIT_MSG@10 PS2, Line 10: https://github.com/amd/firmware_binaries There are changes, though. Where are they documented? (Please don't say "see b:166107781").

-- To view, visit https://review.coreboot.org/c/coreboot/+/46594 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib193d646bb51cbf7b86f46828033e619c3f70e16 Gerrit-Change-Number: 46594 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Wed, 21 Oct 2020 21:57:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Marshall Dawson (Code Review)

1:46 a.m.

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46594 )

Change subject: 3rdparty/amd_blobs: update submodule pointer ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46594/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46594/2//COMMIT_MSG@10 PS2, Line 10: https://github.com/amd/firmware_binaries The changes are to Picasso's PSP files. It looks like from 0.8.6.7B to 0.8.B.7B https://review.coreboot.org/cgit/amd_blobs.git/tree/picasso/PSP/PSP_ReleaseN...

Sorry, that part should've been handled better. It looks like we also picked up some whitespace, so I'll go clean that up.

...

Please don't say "see b:166107781"

Nope, that's merely a todo to make the changeover. Once patches get pulled into Google's coreboot repo, it allows them to short-URL the CL to their tracking system and vice versa.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46594 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib193d646bb51cbf7b86f46828033e619c3f70e16 Gerrit-Change-Number: 46594 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Wed, 21 Oct 2020 22:46:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

1551

days inactive

1552

days old

coreboot-gerrit@coreboot.org

5 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Felix Held (Code Review)
Marshall Dawson (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)