Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47638 )
Change subject: payloads: Force sub-make runs for in-tree payloads ......................................................................
payloads: Force sub-make runs for in-tree payloads
The sub-process calls break make's dependency tracking, hence we have to always perform the calls if we want to allow automatic, incremental builds.
Change-Id: I1bc2406db371e8dddbfdf71f68a6665a5b558f5e Signed-off-by: Nico Huber nico.h@gmx.de --- M payloads/Makefile.inc 1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/47638/1
diff --git a/payloads/Makefile.inc b/payloads/Makefile.inc index ec42143..d89b5ba 100644 --- a/payloads/Makefile.inc +++ b/payloads/Makefile.inc @@ -29,12 +29,14 @@ payloads/external/LinuxBoot \ payloads/external/Yabits \
+force-payload: + payloads/coreinfo/build/coreinfo.elf coreinfo: export CCACHE := $(CCACHE) -payloads/coreinfo/build/coreinfo.elf coreinfo: +payloads/coreinfo/build/coreinfo.elf coreinfo: force-payload $(MAKE) -C payloads/coreinfo defaultbuild
payloads/nvramcui/build/nvramcui.elf nvramcui: export CCACHE := $(CCACHE) -payloads/nvramcui/build/nvramcui.elf nvramcui: +payloads/nvramcui/build/nvramcui.elf nvramcui: force-payload $(MAKE) -C payloads/nvramcui
clean-payloads: @@ -46,4 +48,5 @@ print-repo-info-payloads: -$(foreach payload, $(PAYLOADS_LIST), $(MAKE) -C $(payload) print-repo-info 2>/dev/null; )
-.PHONY: clean-payloads distclean-payloads print-repo-info-payloads nvramcui coreinfo +.PHONY: force-payload coreinfo nvramcui +.PHONY: clean-payloads distclean-payloads print-repo-info-payloads
Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47638 )
Change subject: payloads: Force sub-make runs for in-tree payloads ......................................................................
Patch Set 3: Code-Review+1
Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47638 )
Change subject: payloads: Force sub-make runs for in-tree payloads ......................................................................
Patch Set 4: Code-Review+2
Attention is currently required from: Nico Huber. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47638
to look at the new patch set (#5).
Change subject: payloads: Force sub-make runs for in-tree payloads ......................................................................
payloads: Force sub-make runs for in-tree payloads
The sub-process calls break make's dependency tracking, hence we have to always perform the calls if we want to allow automatic, incremental builds.
We let each rule depend on a new, phony target `force-payload`. It has roughly the same effect as tagging all the targets as phony, but doing so would feel wrong as some of them are actual files.
Change-Id: I1bc2406db371e8dddbfdf71f68a6665a5b558f5e Signed-off-by: Nico Huber nico.h@gmx.de --- M payloads/Makefile.inc 1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/47638/5
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47638 )
Change subject: payloads: Force sub-make runs for in-tree payloads ......................................................................
payloads: Force sub-make runs for in-tree payloads
The sub-process calls break make's dependency tracking, hence we have to always perform the calls if we want to allow automatic, incremental builds.
We let each rule depend on a new, phony target `force-payload`. It has roughly the same effect as tagging all the targets as phony, but doing so would feel wrong as some of them are actual files.
Change-Id: I1bc2406db371e8dddbfdf71f68a6665a5b558f5e Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/47638 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M payloads/Makefile.inc 1 file changed, 6 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/payloads/Makefile.inc b/payloads/Makefile.inc index ec42143..d89b5ba 100644 --- a/payloads/Makefile.inc +++ b/payloads/Makefile.inc @@ -29,12 +29,14 @@ payloads/external/LinuxBoot \ payloads/external/Yabits \
+force-payload: + payloads/coreinfo/build/coreinfo.elf coreinfo: export CCACHE := $(CCACHE) -payloads/coreinfo/build/coreinfo.elf coreinfo: +payloads/coreinfo/build/coreinfo.elf coreinfo: force-payload $(MAKE) -C payloads/coreinfo defaultbuild
payloads/nvramcui/build/nvramcui.elf nvramcui: export CCACHE := $(CCACHE) -payloads/nvramcui/build/nvramcui.elf nvramcui: +payloads/nvramcui/build/nvramcui.elf nvramcui: force-payload $(MAKE) -C payloads/nvramcui
clean-payloads: @@ -46,4 +48,5 @@ print-repo-info-payloads: -$(foreach payload, $(PAYLOADS_LIST), $(MAKE) -C $(payload) print-repo-info 2>/dev/null; )
-.PHONY: clean-payloads distclean-payloads print-repo-info-payloads nvramcui coreinfo +.PHONY: force-payload coreinfo nvramcui +.PHONY: clean-payloads distclean-payloads print-repo-info-payloads
-
Angel Pons (Code Review) -
Nico Huber (Code Review)