Attention is currently required from: Christian Walter, Intel coreboot Reviewers, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Patrick Rudolph, Shuo Liu, Tim Chu.
Paul Menzel has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85806?usp=email )
Change subject: cpu/x86/64bit: Install extended page tables in BSS
......................................................................
Patch Set 6:
(4 comments)
File src/cpu/x86/64bit/mmu.c:
https://review.coreboot.org/c/coreboot/+/85806/comment/88a901cc_771e434e?usp... :
PS6, Line 45: PT),
fits on the line above.
https://review.coreboot.org/c/coreboot/+/85806/comment/91053c69_a4702e7c?usp... :
PS6, Line 132: uint64_t *limit = (uint64_t *)gp;
Add a blank line above?
https://review.coreboot.org/c/coreboot/+/85806/comment/5f506ca1_3e8a99e9?usp... :
PS6, Line 160: if (cpu_supports_1gb_hugepage())
: return BITS_PER_VA_LVL4;
: return 40;
```suggestion
return cpu_supports_1gb_hugepage() ? BITS_PER_VA_LVL4 : 40;
```
https://review.coreboot.org/c/coreboot/+/85806/comment/26e6b0dc_1f5f0edf?usp... :
PS6, Line 178: printk(BIOS_DEBUG, "MMU: Upper MEM limit is 0x%llx\n", limit);
: printk(BIOS_DEBUG, "MMU: New page tables are%s required\n",
: (limit > mmu_default_map_size()) ? "" : "n't");
Also log mmu_default_map_size()?
MMU: New page tables are%s required (limit = x, default map size = y)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85806?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifab50975e0382a1f5c27b55bca1dbbb66b37ba3a
Gerrit-Change-Number: 85806
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jincheng Li
jincheng.li@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 25 Feb 2025 15:17:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No